[PATCH] D66454: [MemorySSA] Make Phi cleanups consistent.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

Assuming the test in D66495 <https://reviews.llvm.org/D66495> (in part) covers this, LGTM with an optional nit.

Thanks!



================
Comment at: lib/Analysis/MemorySSAUpdater.cpp:494
+    auto OperRange = MPhi->operands();
+    tryRemoveTrivialPhi(MPhi, OperRange);
   }
----------------
do we have many more calls like this laying around?

if so, would it be good to add a super simple overload that just takes a `MPhi`, asserts it's non-null, and expands to `tryRemoveTrivialPhi(MPhi, MPhi->operands());`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66454/new/

https://reviews.llvm.org/D66454