[PATCH] D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 14:18:34 PDT 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM aside from some minor nits.



================
Comment at: llvm/include/llvm/Support/Compiler.h:19
 
+#if __cplusplus
 #include <new>
----------------
`#if defined(__cplusplus)` please


================
Comment at: llvm/include/llvm/Support/Compiler.h:530
 
+#if __cplusplus
 namespace llvm {
----------------
`#if defined(__cplusplus)` here as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66487/new/

https://reviews.llvm.org/D66487





More information about the llvm-commits mailing list