[PATCH] D66191: [AutoFDO] Make call targets order deterministic for sample profil

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 13:46:06 PDT 2019


wenlei marked 2 inline comments as done.
wenlei added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1299
+  for (const auto &I : SampleRecord::SortCallTargets(M)) {
+    R.push_back({FunctionSamples::getGUID(I.first), I.second});
+  }
----------------
wmi wrote:
> Nit: emplace may be better. 
Thanks for review. Now changed to emplace_back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66191/new/

https://reviews.llvm.org/D66191





More information about the llvm-commits mailing list