[PATCH] D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: llvm/include/llvm/Support/Compiler.h:258
 #elif !__cplusplus
 // Workaround for llvm.org/PR23435, since clang 3.6 and below emit a spurious
 // error when __has_cpp_attribute is given a scoped attribute in C mode.
----------------
Move comment below?


================
Comment at: llvm/include/llvm/Support/Compiler.h:580
 #endif
+#endif
----------------
#endif // __cplusplus

?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66487/new/

https://reviews.llvm.org/D66487