[PATCH] D66418: [llvm-objdump] - Cleanup the error reporting.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 12:45:46 PDT 2019

Previous message: [PATCH] D66418: [llvm-objdump] - Cleanup the error reporting.
Next message: [PATCH] D66418: [llvm-objdump] - Cleanup the error reporting.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

rupprecht added a comment.

+1 to changing `report_error`->`reportError`, same for `reportWarning`. I suppose it can be a followup NFC patch since it's technically consistent with the existing code. LGTM to the rest.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66418/new/

https://reviews.llvm.org/D66418

Previous message: [PATCH] D66418: [llvm-objdump] - Cleanup the error reporting.
Next message: [PATCH] D66418: [llvm-objdump] - Cleanup the error reporting.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list