[PATCH] D66482: [lit] Diagnose insufficient args to internal env

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 12:29:58 PDT 2019


jdenny updated this revision to Diff 216213.
jdenny added a comment.

Replace `ValueError` with `InternalShellError` as just discussed in D65697 <https://reviews.llvm.org/D65697>.  I'll wait a little while to push in case someone wants to comment on this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66482/new/

https://reviews.llvm.org/D66482

Files:
  llvm/utils/lit/lit/TestRunner.py
  llvm/utils/lit/tests/Inputs/shtest-env/env-args-last-is-assign.txt
  llvm/utils/lit/tests/Inputs/shtest-env/env-args-last-is-u-arg.txt
  llvm/utils/lit/tests/Inputs/shtest-env/env-args-last-is-u.txt
  llvm/utils/lit/tests/Inputs/shtest-env/env-args-none.txt
  llvm/utils/lit/tests/shtest-env.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66482.216213.patch
Type: text/x-patch
Size: 3925 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190820/df55ecb1/attachment.bin>


More information about the llvm-commits mailing list