[PATCH] D66191: [AutoFDO] Make call targets order deterministic for sample profil

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 11:28:15 PDT 2019


wmi accepted this revision.
wmi added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!



================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1299
+  for (const auto &I : SampleRecord::SortCallTargets(M)) {
+    R.push_back({FunctionSamples::getGUID(I.first), I.second});
+  }
----------------
Nit: emplace may be better. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66191/new/

https://reviews.llvm.org/D66191





More information about the llvm-commits mailing list