[PATCH] D59945: [ObjCMetadata] Add support for reading Objective-C metadata

Juergen Ributzka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 11:02:29 PDT 2019


ributzka added inline comments.


================
Comment at: llvm/include/llvm/Object/ObjCMetadata/ObjCBitcode.h:31
+  bool isObjC2() const override;
+  Expected<StringRef> getSwiftVersion() const override;
+
----------------
We could change the interface to 
```
Expected<unsigned> getSwiftABIVersion() const
```
instead. That removes the need to map the ABI version to a string.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59945/new/

https://reviews.llvm.org/D59945





More information about the llvm-commits mailing list