[PATCH] D66303: [LifetimeAnalysis] Add support for free functions

[Gábor Horváth via Phabricator via llvm-commits]

xazax.hun marked 2 inline comments as done.
xazax.hun added inline comments.


================
Comment at: clang/lib/Sema/SemaInit.cpp:6622
+    return false;
+  const auto *RD = FD->getParamDecl(0)->getType()->getPointeeCXXRecordDecl();
+  if (!FD->isInStdNamespace() || !RD || !RD->isInStdNamespace())
----------------
mgehre wrote:
> Maybe move the `Callee->getNumParams() == 1` check from the caller into this function so it's obvious that `getParamDecl(0)` is allowed?
Thanks, I addressed this one before committing.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66303/new/

https://reviews.llvm.org/D66303