[PATCH] D66476: [llvm-objcopy][test] Add a test to show that argv[0] is included in error/warning messages

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 08:05:42 PDT 2019


MaskRay marked 2 inline comments as done.
MaskRay added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/error-format.test:18
+  Type:    ET_DYN
+  Machine: EM_RISCV
----------------
grimar wrote:
> Seems not important at all, but `EM_RISCV`? I'd use something more common instead, probably.
I think this is probably not important... It just adds some variety for unimportant fields..


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66476/new/

https://reviews.llvm.org/D66476





More information about the llvm-commits mailing list