[PATCH] D66475: [llvm-objcopy] Append '\n' to warning messages
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 20 07:59:02 PDT 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL369391: [llvm-objcopy] Append '\n' to warning messages (authored by MaskRay, committed by ).
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66475/new/
https://reviews.llvm.org/D66475
Files:
llvm/trunk/test/tools/llvm-objcopy/ELF/same-file-strip.test
llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp
Index: llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp
===================================================================
--- llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp
+++ llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp
@@ -84,7 +84,7 @@
ErrorSuccess reportWarning(Error E) {
assert(E);
- WithColor::warning(errs(), ToolName) << toString(std::move(E));
+ WithColor::warning(errs(), ToolName) << toString(std::move(E)) << '\n';
return Error::success();
}
Index: llvm/trunk/test/tools/llvm-objcopy/ELF/same-file-strip.test
===================================================================
--- llvm/trunk/test/tools/llvm-objcopy/ELF/same-file-strip.test
+++ llvm/trunk/test/tools/llvm-objcopy/ELF/same-file-strip.test
@@ -9,10 +9,11 @@
# ERR: error: cannot specify '-' as an input file more than once
-# RUN: llvm-strip %t %t 2>&1 | FileCheck -check-prefix=WARN %s -DFILE=%t
-# RUN: llvm-strip %t %t %t 2>&1 | FileCheck -check-prefix=WARN %s -DFILE=%t
+# RUN: cp %t %t2
+# RUN: llvm-strip %t %t %t %t2 %t2 2>&1 | FileCheck -check-prefix=WARN %s -DFILE=%t -DFILE2=%t2
-# WARN: warning: '[[FILE]]' was already specified
+# WARN: warning: '[[FILE]]' was already specified
+# WARN-NEXT: warning: '[[FILE2]]' was already specified
--- !ELF
FileHeader:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66475.216150.patch
Type: text/x-patch
Size: 1280 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190820/b51334b2/attachment.bin>
More information about the llvm-commits
mailing list