[PATCH] D66415: [DebugInfo at O2] Fix PR41992: LiveDebugVariables can drop DBG_VALUEs through misinterpreting fragments

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

Thanks for the review!

> I do wonder wonder why the patch goes out of its way to save fragment infos when fragments don't appear in the test at all?

The fragment info changes were a natural path since the DIExpression could no longer be used to identify the UserValues, but failing to test any IR with fragments was an oversight for sure.

> Two (partially) overlapping fragments should be handled as if they are describing the same variable.

I hadn't considered the 'partially' case, I'll look into this now. I think my current patch will change shape a bit as a result.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66415/new/

https://reviews.llvm.org/D66415