[PATCH] D66410: [ARM] Select vaddva

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 07:34:53 PDT 2019


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM, thanks.

Its sometimes hard to tell if these functions exactly match up to that they are replacing, with all the extends going on. I believe this one is OK, but make sure it's tested.



================
Comment at: llvm/test/CodeGen/Thumb2/mve-vaddv.ll:38
+
+define arm_aapcs_vfpcc i64 @vaddva_v2i64_i64(<2 x i64> %s1, i64 %x) {
+; CHECK-LABEL: vaddva_v2i64_i64:
----------------
Can you add one for vaddv too, just before you commit?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66410/new/

https://reviews.llvm.org/D66410





More information about the llvm-commits mailing list