[PATCH] D66474: MinidumpYAML: move serialization code to MinidumpEmitter.cpp

[Pavel Labath via Phabricator via llvm-commits]

labath created this revision.
labath added reviewers: jhenderson, abrachet.
Herald added a project: LLVM.

The code for serializing minidumps was living in MinidumpYAML.cpp
so that it would be accessible from unit tests. While this had its
advantages, it was also unfortunate because it broke symmetry with all
other yaml2obj serializers.

Fortunately, nowadays all of yaml2obj is a library, so we don't need to
do anything special. This patch improves the code consistency by moving
the serialization code to MinidumpEmitter.cpp to match the style used in
other backends. It also removes the writeAsBinary entry point in favor
of the more general convertYAML interface.

This patch is just massaging the code a bit. There shouldn't be any
functional change here.


Repository:
  rL LLVM

https://reviews.llvm.org/D66474

Files:
  include/llvm/ObjectYAML/MinidumpYAML.h
  lib/ObjectYAML/MinidumpEmitter.cpp
  lib/ObjectYAML/MinidumpYAML.cpp
  unittests/ObjectYAML/MinidumpYAMLTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66474.216139.patch
Type: text/x-patch
Size: 16995 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190820/43b0454d/attachment.bin>