[PATCH] D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 20 06:05:43 PDT 2019
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with one nit.
================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:373
+ // If we have an error getting the name then we print the index of the archive
+ // member. Since we are already in a error state, we just ignore this error.
+ consumeError(NameOrErr.takeError());
----------------
a error -> an error
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66468/new/
https://reviews.llvm.org/D66468
More information about the llvm-commits
mailing list