[PATCH] D66425: [llvm-readobj] Prepend argv[0] to error messages

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 05:17:42 PDT 2019


MaskRay added inline comments.


================
Comment at: test/tools/llvm-readobj/error-format.test:9-12
+# RUN: llvm-readelf -x 10 %S/Inputs/trivial.obj.elf-x86-64 2>&1 | \
+# RUN:   FileCheck --check-prefix=WARN-READELF %s
+# RUN: llvm-readobj -x 10 %S/Inputs/trivial.obj.elf-x86-64 2>&1 | \
+# RUN:   FileCheck --check-prefix=WARN-READOBJ %s
----------------
jhenderson wrote:
> I think we should probably just use yaml2obj here instead of relying on pre-built binaries. I don't feel strongly about it though.
 This is the simplest way to get a warning. I don't want to be distracted by the lengthy YAML...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66425/new/

https://reviews.llvm.org/D66425





More information about the llvm-commits mailing list