[PATCH] D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 04:48:24 PDT 2019


grimar added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:441
 
-LLVM_ATTRIBUTE_NORETURN void report_error(Error E, StringRef ArchiveName,
+LLVM_ATTRIBUTE_NORETURN void report_error1(Error E, StringRef ArchiveName,
                                           const object::Archive::Child &C,
----------------
jhenderson wrote:
> Did you mean to delete this function?
Yes..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66468/new/

https://reviews.llvm.org/D66468





More information about the llvm-commits mailing list