[PATCH] D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 04:28:23 PDT 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: seiya, rupprecht.

One of the `report_error` functions was taking `object::Archive::Child` as an
argument. It feels excessive, this patch removes it and introduce a helper
function instead. Also I fixed a "TODO" in this patch what improved the message printed.


https://reviews.llvm.org/D66468

Files:
  test/tools/llvm-objdump/malformed-archives.test
  tools/llvm-objdump/MachODump.cpp
  tools/llvm-objdump/llvm-objdump.cpp
  tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66468.216097.patch
Type: text/x-patch
Size: 10319 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190820/2cb67aca/attachment.bin>


More information about the llvm-commits mailing list