[PATCH] D66407: [llvm-objcopy][MachO] Implement -Ibinary

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/binary-input.test:1
+# Show that if -I binary is given, llvm-objopy creates a MachO object which
+# contains input file contents.
----------------
If I'm not mistaken, it should be Mach-O here rather than MachO.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/binary-input.test:2
+# Show that if -I binary is given, llvm-objopy creates a MachO object which
+# contains input file contents.
+
----------------
contains the input...


================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOReader.h:9
 
+#include "../CopyConfig.h"
 #include "MachOObjcopy.h"
----------------
You shouldn't need the relative path. You should just be able to do "CopyConfig.h". If that doesn't work, then there's something wrong with the include directories, I think. This might point to a bigger flaw in llvm-objcopy's include paths.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66407/new/

https://reviews.llvm.org/D66407