[PATCH] D66063: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 5]

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 02:18:25 PDT 2019


grimar added inline comments.


================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:501
 
-  const Elf_Ehdr *Header = EF.getHeader();
+  const Elf_Ehdr *Header = &getHeader();
   // Clear the ARM/Thumb or microMIPS indicator flag.
----------------
I'd suggest using a reference here and in the other places. It looks more natural
as `Header` can't be nullptr.

```
onst Elf_Ehdr &Header = getHeader();
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66063/new/

https://reviews.llvm.org/D66063





More information about the llvm-commits mailing list