[PATCH] D66155: [Attributor] Liveness for internal functions.

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 02:18:25 PDT 2019


sstefan1 marked 5 inline comments as done.
sstefan1 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1878
+        Status = ChangeStatus::CHANGED;
+      }
     }
----------------
jdoerfert wrote:
> I'm confused. When do we need this status flag here, I mean why isn't the one above sufficient. And if this one is needed, why only if we find a new `NextNoReturnI` and not once the path size changes (as before)?
This was actually a leftover. I was trying things when I thought I messed something with verification.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66155/new/

https://reviews.llvm.org/D66155





More information about the llvm-commits mailing list