[PATCH] D65541: [llvm-objcopy][MachO] Implement --only-section

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/only-section.test:15
+
+## Specify __TEXT,__text. The output file should contain only the section.
+# RUN: llvm-objcopy --only-section __TEXT,__text %t %t4
----------------
"Specify `__TEXT,__text`" -> "Specify one section."
"only the" -> "only that"


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/only-section.test:58-59
+
+## Remove all sections without warning if the specified section name is not
+## present in the input.
+# RUN: llvm-objcopy --only-section __TEXT,__nonexistent %t %t5
----------------
You say "without warning" here, but don't actually check for a warning, which you probably should do, if you're going to mention it in the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65541/new/

https://reviews.llvm.org/D65541