[PATCH] D65242: [ELF] More dynamic relocation packing

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/SyntheticSections.cpp:1787
+  // Grouped non-relatives.
+  for (std::vector<Elf_Rela> &g : nonRelativeGroups) {
+    add(g.size());
----------------
We generally use `ArrayRef<T>` instead of `std::vector<T> &` in LLVM if it can be a read-only variable. Can you use `ArrayRef<Elf_Rela>` instead of `std::vector<Elf_Rela> &`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65242/new/

https://reviews.llvm.org/D65242