[PATCH] D66425: [llvm-readobj] Prepend argv[0] to error messages

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/llvm-readobj/error-format.test:7
+# READELF: llvm-readelf: error: '{{.*}}':
+# READOBJ: llvm-readobj: error: '{{.*}}':
----------------
grimar wrote:
> It fails under windows for me. Because of `.exe` suffix:
> 
> ```
> D:\Work2\llvm\llvm\test\tools\llvm-readobj\error-format.test:6:12: error: READELF: expected string not found in input
> # READELF: llvm-readelf: error: '{{.*}}':
>            ^
> <stdin>:2:1: note: scanning from here
> d:\work2\llvm\llvm_build\debug\bin\llvm-readelf.exe: error: 'D:\Work2\llvm\llvm\
> test\tools\llvm-readobj/non-existent': no such file or directory
> ^
> ```
The following helps:

```
# READELF: llvm-readelf{{(.exe)?}}: error: '{{.*}}':
# READOBJ: llvm-readobj{{(.exe)?}}: error: '{{.*}}':
```

(no more other readelf tests are failing for me, btw).

I see that out other tests sometimes using something like: `llvm-ar{{(.exe|.EXE)?}}`,
but I am not sure why handling the uppercase `.EXE` is useful/important.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66425/new/

https://reviews.llvm.org/D66425