[PATCH] D66062: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 4]

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Object/MutableELFObject.h:42
+
+  MutableELFSection(MutableELFSection &&Other) = default;
+
----------------
Omit `Other`, but why do you need the defaulted move ctor?


================
Comment at: llvm/include/llvm/Object/MutableELFObject.h:176
+      NewValues.emplace_back(std::move(Value));
+      Mappings.emplace_back(NewValues.size() - 1, MappingType::New);
+    }
----------------
Swap the two statements to omit `- 1`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66062/new/

https://reviews.llvm.org/D66062