[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 22:47:10 PDT 2019


echristo added a comment.

In D65410#1613555 <https://reviews.llvm.org/D65410#1613555>, @hfinkel wrote:

> Thanks for starting on this. Can you go ahead and replace the sroa calls with mem2reg calls for `O1` and then see what that does to the performance? That strikes me as a major change, but certainly one that potentially makes sense, so I'd rather we go ahead and test it now before we make decisions about other adjustments.


I'll give it a shot. I think we'll want it in the long run, but happy to run it through the performance blender just to get an idea of what we're getting for our complexity.

> FWIW, I thought that we might run InstCombine less often (or maybe replace it with InstSimplify, in some places). Did you try that?

I haven't. It's one part of pass ordering that we'll want to look at, but I figured some optimizing here could happen later. Happy to try a few things though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65410/new/

https://reviews.llvm.org/D65410





More information about the llvm-commits mailing list