[PATCH] D66264: [ThinLTO] Fix handling of weak interposable symbols

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM

This would also be fixed by switching to canonical aliases, right? Maybe another data point in favour of finally switching.



================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:911-912
 bool llvm::convertToDeclaration(GlobalValue &GV) {
+  //errs() << "Converting to a declaration:\n";
+  //GV.dump();
   LLVM_DEBUG(dbgs() << "Converting to a declaration: `" << GV.getName()
----------------
Unintentional?


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:942-943
   }
+  //errs() << "After:\n";
+  //GV.dump();
   return true;
----------------
Ditto


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66264/new/

https://reviews.llvm.org/D66264