[llvm] r369310 - [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC
Hubert Tong via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 19 16:12:48 PDT 2019
Author: hubert.reinterpretcast
Date: Mon Aug 19 16:12:48 2019
New Revision: 369310
URL: http://llvm.org/viewvc/llvm-project?rev=369310&view=rev
Log:
[cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC
Summary:
rL367756 (f5c40cb) increases the dependency of LLVMOrcJIT on LLVMPasses.
In particular, symbols defined in LLVMPasses that are referenced by the
destructor of `PassBuilder` are now referenced by LLVMOrcJIT through
`Speculation.cpp.o`.
We believe that referencing symbols defined in LLVMPasses in the
destructor of `PassBuilder` is valid, and that adding to the set of such
symbols is legitimate. To support such cases, this patch adds LLVMPasses
to the set of libraries being linked when linking in LLVMOrcJIT causes
such symbols from LLVMPasses to be referenced.
Reviewers: Whitney, anhtuyen, pree-jackie
Reviewed By: pree-jackie
Subscribers: mgorny, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66441
Modified:
llvm/trunk/lib/ExecutionEngine/Orc/CMakeLists.txt
llvm/trunk/tools/lli/CMakeLists.txt
llvm/trunk/unittests/ExecutionEngine/Orc/CMakeLists.txt
Modified: llvm/trunk/lib/ExecutionEngine/Orc/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/CMakeLists.txt?rev=369310&r1=369309&r2=369310&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/Orc/CMakeLists.txt (original)
+++ llvm/trunk/lib/ExecutionEngine/Orc/CMakeLists.txt Mon Aug 19 16:12:48 2019
@@ -35,4 +35,5 @@ target_link_libraries(LLVMOrcJIT
LLVMAnalysis
LLVMBitReader
LLVMBitWriter
+ LLVMPasses
)
Modified: llvm/trunk/tools/lli/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lli/CMakeLists.txt?rev=369310&r1=369309&r2=369310&view=diff
==============================================================================
--- llvm/trunk/tools/lli/CMakeLists.txt (original)
+++ llvm/trunk/tools/lli/CMakeLists.txt Mon Aug 19 16:12:48 2019
@@ -12,6 +12,7 @@ set(LLVM_LINK_COMPONENTS
MCJIT
Object
OrcJIT
+ Passes
RuntimeDyld
SelectionDAG
Support
Modified: llvm/trunk/unittests/ExecutionEngine/Orc/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/Orc/CMakeLists.txt?rev=369310&r1=369309&r2=369310&view=diff
==============================================================================
--- llvm/trunk/unittests/ExecutionEngine/Orc/CMakeLists.txt (original)
+++ llvm/trunk/unittests/ExecutionEngine/Orc/CMakeLists.txt Mon Aug 19 16:12:48 2019
@@ -4,6 +4,7 @@ set(LLVM_LINK_COMPONENTS
ExecutionEngine
Object
OrcJIT
+ Passes
RuntimeDyld
Support
native
More information about the llvm-commits
mailing list