[PATCH] D66438: [llvm-extract] Update the help message for group extraction feature

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi Jinsong,

Good catch.

Comment below.

Cheers,
-Quentin



================
Comment at: llvm/tools/llvm-extract/llvm-extract.cpp:78
+    "bb",
+    cl::desc("Specify <function, basic block[;group]> pairs to extract, "
+             "region must be single entry."),
----------------
I find the use of "group" here confusing.
Maybe we should stick to <function, basic block1[;basic block2...]> like you did in the value_desc.

Maybe also specify that func:bb1;bb2 is not equivalent to func:bb1 func:bb2 (1 function created with bb1 + bb2, vs. two function created; one with bb1, one with bb2).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66438/new/

https://reviews.llvm.org/D66438