[PATCH] D66293: [lit] Check for accidental external command calls
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 19 15:34:40 PDT 2019
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
I was actually misunderstanding how lit/tests/lit.cfg fit in, and reacting to the comment about piping in lit.cfg. The top-level description actually looks okay. It makes sense to verify lit itself is behaving as desired in lit's own test suite, and not add these external commands to the PATH of all tests.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66293/new/
https://reviews.llvm.org/D66293
More information about the llvm-commits
mailing list