[PATCH] D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 15:28:05 PDT 2019


aprantl added inline comments.


================
Comment at: include/llvm/DebugInfo/GSYM/FileWriter.h:40
+  ///
+  /// @param   Value The value to write into the stream.
+  void writeU8(uint8_t Value);
----------------
clayborg wrote:
> aprantl wrote:
> > `/// \param Value`
> Yikes, there is a large mix of both @param and \param in the code... 
\param is the preferred spelling in LLVM code (I thought I had replaced all remaining @'s with backslashes a while ago).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63828/new/

https://reviews.llvm.org/D63828





More information about the llvm-commits mailing list