[PATCH] D66374: [SampleFDO] Add symbol whitelist in the profile and use it when profile-sample-accurate is enabled

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: lib/ProfileData/SampleProf.cpp:222
+  SortedList.insert(SortedList.begin(), Syms.begin(), Syms.end());
+  std::sort(SortedList.begin(), SortedList.end());
+
----------------
Please use a range-based llvm::sort function here. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements.

```
llvm::sort(SortedList);
```


================
Comment at: lib/ProfileData/SampleProf.cpp:245
+  SortedList.insert(SortedList.begin(), Syms.begin(), Syms.end());
+  std::sort(SortedList.begin(), SortedList.end());
+
----------------
Please use a range-based llvm::sort function here. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements.

```
llvm::sort(SortedList);
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66374/new/

https://reviews.llvm.org/D66374