[PATCH] D66293: [lit] Check for accidental external command calls
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 19 14:36:32 PDT 2019
probinson added a comment.
IIUC this means if anyone tries to write a RUN line that pipes something to `diff` or `cd` or whatever, it would explicitly fail. That's probably a good move.
I suspect that `:` is not a legal filename on Windows. I'm not able to create such a file from the Windows CMD shell, and grepping the llvm and clang test suites for 'RUN:.* :' doesn't turn up anything that tries to use `:` as a command. Maybe we should just eliminate that command?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66293/new/
https://reviews.llvm.org/D66293
More information about the llvm-commits
mailing list