[PATCH] D64740: Use the ConvertUTF.cpp from breakpad which is under a compatible licenseAnd reintegrate our custom changes

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 10:27:58 PDT 2019


mgorny added a comment.

@sylvestre.ledru, I just went through breakpad code, comparing it with the initial code imported to clang. After reordering and aligning whitespace, the code is identical. This means that 1) the tests are failing because of regressions reintroduced by porting breakpad code, and 2) we can just change the license header because all differences in code are of our own making. Therefore, I propose that we go forward with D66390 <https://reviews.llvm.org/D66390> instead of putting more time into regressing code just to fix it again.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64740/new/

https://reviews.llvm.org/D64740





More information about the llvm-commits mailing list