[PATCH] D66418: [llvm-objdump] - Cleanup the error reporting.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 07:17:55 PDT 2019


grimar created this revision.
grimar added reviewers: jhenderson, rupprecht, MaskRay.
Herald added a subscriber: seiya.

The error reporting function are not consistent.

Before this change:

- They had inconsistent naming (e.g. 'error' vs 'report_error').
- Some of them them reported the object name, others - dont.
- Some of them accepted the case when there was no error. (i.e. error code or Error had a success value).

This patch tries to cleanup it a bit.

Rebased on top of D66417 <https://reviews.llvm.org/D66417>


https://reviews.llvm.org/D66418

Files:
  test/Object/macho-invalid.test
  test/tools/llvm-objdump/X86/disassemble-functions-mangling.test
  test/tools/llvm-objdump/X86/source-interleave-invalid-source.test
  test/tools/llvm-objdump/X86/source-interleave-missing-source.test
  test/tools/llvm-objdump/X86/source-interleave-no-debug-info.test
  test/tools/llvm-objdump/X86/warn-missing-disasm-func.test
  test/tools/llvm-objdump/warn-on-out-of-range-start-stop-address.test
  tools/llvm-objdump/COFFDump.cpp
  tools/llvm-objdump/ELFDump.cpp
  tools/llvm-objdump/MachODump.cpp
  tools/llvm-objdump/llvm-objdump.cpp
  tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66418.215885.patch
Type: text/x-patch
Size: 25781 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190819/db404260/attachment.bin>


More information about the llvm-commits mailing list