[PATCH] D66417: [Object/COFF.h] - Stop returning std::error_code in a few methods. NFCI.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 19 06:35:39 PDT 2019
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with one nit.
================
Comment at: tools/llvm-objdump/COFFDump.cpp:300
static void printLoadConfiguration(const COFFObjectFile *Obj) {
- // Skip if it's not executable.
- const pe32_header *PE32Header;
----------------
You've lost the comment here. Please reinstate it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66417/new/
https://reviews.llvm.org/D66417
More information about the llvm-commits
mailing list