[PATCH] D66408: [llvm-objcopy][MachO] Implement --dump-section

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/dump-section.test:11
+
+## Error case 2: A nonexistent section name.
+# RUN: not llvm-objcopy --dump-section __TEXT,__foo=%t.no-such-section %t 2>&1 \
----------------
Nit: nonexistent -> non-existent


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/dump-section.test:16
+
+## Extract section contents into files.
+# RUN: llvm-objcopy --dump-section __TEXT,__text=%t.dump.text \
----------------
It probably makes more sense to put the positive cases before the negative ones.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66408/new/

https://reviews.llvm.org/D66408