[PATCH] D66409: [llvm-objcopy][MachO] Implement -Obinary

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/binary-output.test:1
+## Show that llvm-objcopy extracts section contents in MachO properly, that is:
+##
----------------
How about "Shows that for binary output, llvm-objcopy extracts ..."?


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/binary-output.test:3
+##
+##   - Remove gap before the first section: __bar section content is at the
+##     beginning of the output.
----------------
Remove gap -> It removes any gap


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/binary-output.test:5
+##     beginning of the output.
+##   - Preserve gaps between sections: 12 bytes padding (zeroes) before __foo
+##     section content.
----------------
Preserve gaps -> It preserves any gaps


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66409/new/

https://reviews.llvm.org/D66409