[PATCH] D66130: [ELF] Initialize 2 fields of Symbol in SymbolTable::insert

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 04:39:01 PDT 2019


ruiu added a comment.

It might make sense to zero-initialize a new instance with `memset(sym, 0, sizeof(Symbol))` before setting any (non-zero/false) values to sym members, as it is less error-prone. What do you think?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66130/new/

https://reviews.llvm.org/D66130





More information about the llvm-commits mailing list