[PATCH] D66279: [ELF] Make LinkerScript::assignAddresses iterative

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 01:06:23 PDT 2019


ruiu added inline comments.


================
Comment at: ELF/Writer.cpp:1578
+    if (changed && tc.pass >= 10)
+      fatal("thunk creation not converged");
 
----------------
I believe this line is executed only when you give pathetic object files to the linker, but we still probably have to use `error` to make it work better for the embedding use case.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66279/new/

https://reviews.llvm.org/D66279





More information about the llvm-commits mailing list