[PATCH] D66359: [lld][WebAssembly] Honor --no-export-dynamic even with -shared

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/test/wasm/shared-export-dynamic.ll:19-20
+}
+
+
----------------
nit: delete trailing blank lines


================
Comment at: lld/wasm/Driver.cpp:362
+  config->exportDynamic = args.hasFlag(
+      OPT_export_dynamic, OPT_no_export_dynamic, exportDynamicDefault);
+
----------------
Maybe removing this temporary variable and directly using config->shared is little simpler?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66359/new/

https://reviews.llvm.org/D66359