[PATCH] D66367: [LLD] [COFF] Require an explicit -implib option for creating implibs in mingw mode

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: COFF/Driver.cpp:1852
   // Windows specific -- when we are creating a .dll file, we also
   // need to create a .lib file.
+  bool createImpLib;
----------------
... In MinGW mode, we do that only when -implib option is explicitly given for compatibility with GNU ld.


================
Comment at: test/COFF/implib-name-mingw.test:13
+RUN: lld-link -dll -machine:x64 -def:%S/Inputs/named.def -out:%t-out/library.dll %t-out/object.obj -entry:f -subsystem:console
+RUN: test -f %t-out/library.lib
+
----------------
I believe using test command is OK, as we are already using some other basic commands such as tar.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66367/new/

https://reviews.llvm.org/D66367