[PATCH] D66403: Create MutableObjectWriter class

[Alex Brachet via Phabricator via llvm-commits]

abrachet marked an inline comment as done.
abrachet added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.h:1167
+  Sec.Header.sh_offset = CurrentOffset;
+  Sec.Header.sh_name = 0; // ShstrBuilder.getOffset(StringRef(Sec.Name));
+  if (Sec.Header.sh_type != ELF::SHT_NOBITS)
----------------
I'm not sure if I'm using `StringTableBuilder` incorrectly. An assertion failed saying that the string was not in the table. I looked into it with lldb and manually added the string it said was not there, it still didn't work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66403/new/

https://reviews.llvm.org/D66403