[PATCH] D64740: Use the ConvertUTF.cpp from breakpad which is under a compatible licenseAnd reintegrate our custom changes

[Sylvestre Ledru via Phabricator via llvm-commits]

sylvestre.ledru marked an inline comment as done.
sylvestre.ledru added inline comments.


================
Comment at: unittests/Support/ConvertUTFTest.cpp:166
 
-std::pair<ConversionResult, std::vector<unsigned>>
-ConvertUTF8ToUnicodeScalarsPartialLenient(StringRef S) {
-  const UTF8 *SourceStart = reinterpret_cast<const UTF8 *>(S.data());
-
-  const UTF8 *SourceNext = SourceStart;
-  std::vector<UTF32> Decoded(S.size(), 0);
-  UTF32 *TargetStart = Decoded.data();
+// std::pair<ConversionResult, std::vector<unsigned long>>
+// ConvertUTF8ToUnicodeScalarsPartialLenient(StringRef S) {
----------------
mgorny wrote:
> Why is this commented out? It looks at least weird, with no comment to explain it.
I think i removed it to build.
It should indeed be fixed or commented 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64740/new/

https://reviews.llvm.org/D64740