[PATCH] D64740: Use the ConvertUTF.cpp from breakpad which is under a compatible licenseAnd reintegrate our custom changes

[Michał Górny via Phabricator via llvm-commits]

mgorny added a comment.

Any chance to move this forward? I've just noticed we're missing this one license, and fixing it would render LLVM non-free in Gentoo (read: cause a massive shitstorm for some of our users). I just wanted to do a similar port and found this while looking for earlier work.



================
Comment at: unittests/Support/ConvertUTFTest.cpp:166
 
-std::pair<ConversionResult, std::vector<unsigned>>
-ConvertUTF8ToUnicodeScalarsPartialLenient(StringRef S) {
-  const UTF8 *SourceStart = reinterpret_cast<const UTF8 *>(S.data());
-
-  const UTF8 *SourceNext = SourceStart;
-  std::vector<UTF32> Decoded(S.size(), 0);
-  UTF32 *TargetStart = Decoded.data();
+// std::pair<ConversionResult, std::vector<unsigned long>>
+// ConvertUTF8ToUnicodeScalarsPartialLenient(StringRef S) {
----------------
Why is this commented out? It looks at least weird, with no comment to explain it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64740/new/

https://reviews.llvm.org/D64740