[PATCH] D64827: [Xtensa 2/10] Add Xtensa ELF definitions.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/ELF.h:772
+enum : unsigned {
+  /* Four-bit Xtensa machine type field.  */
+  EF_XTENSA_MACH = 0x0000000f,
----------------
Use `//` as the rest of the file uses.


================
Comment at: llvm/include/llvm/BinaryFormat/ELFRelocs/Xtensa.def:1
+#ifndef ELF_RELOC
+#error "ELF_RELOC must be defined"
----------------
Add a test test/tools/llvm-readobj/reloc-types-elf-xtensa.test


================
Comment at: llvm/test/Object/Xtensa/elf-flags.yaml:1
+# RUN: yaml2obj %s > %t
+# RUN: llvm-readobj -file-headers %t | FileCheck -check-prefix=OBJ %s
----------------
Delete this file. Add to test/Object/obj2yaml.test instead. You may follow the ELF-X86-64: yaml2obj+obj2yaml test.


================
Comment at: llvm/test/Object/Xtensa/lit.local.cfg:3
+    config.unsupported = True
+
----------------
Delete this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64827/new/

https://reviews.llvm.org/D64827