[PATCH] D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 17 20:28:27 PDT 2019


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:115
 
+struct XCOFFCSectAuxEnt {
+  support::ubig32_t SectionLen;
----------------
`XCOFFCSectAuxEnt32`.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:117
+  support::ubig32_t SectionLen;
+  support::ubig32_t ParameterHash;
+  support::ubig16_t TypeChkSectNum;
----------------
This does not hold the hash value itself, so `ParameterHashIndex`.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:121
+  XCOFF::StorageMappingClass StorageMappingClass;
+  support::ubig32_t Stab;
+  support::ubig16_t Snstab;
----------------
`StabInfoIndex`, like `ParameterHashIndex`.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:122
+  support::ubig32_t Stab;
+  support::ubig16_t Snstab;
+};
----------------
`StabSecNum`, like `TypeChkSectNum`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65240/new/

https://reviews.llvm.org/D65240





More information about the llvm-commits mailing list