[PATCH] D66338: [CGP] Drop llvm.assume calls

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

In D66338#1634061 <https://reviews.llvm.org/D66338#1634061>, @xbolva00 wrote:

> Anyway I think this fix is good and simple - does not require individual fixes for GlobalISel, FastISel, SelectionDAG.


Indeed. But this situation is not unique to assume. The relevant code in SDAGBuilder has:

  case Intrinsic::assume:
  case Intrinsic::var_annotation:
  case Intrinsic::sideeffect:
    // Discard annotate attributes, assumptions, and artificial side-effects.
    return;

can we drop all of them at this point, or is it only safe to drop assumes there?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66338/new/

https://reviews.llvm.org/D66338