[llvm] r369192 - [llvm-readobj] - An attemp to fix BB after r369191.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 17 08:24:16 PDT 2019
Author: grimar
Date: Sat Aug 17 08:24:16 2019
New Revision: 369192
URL: http://llvm.org/viewvc/llvm-project?rev=369192&view=rev
Log:
[llvm-readobj] - An attemp to fix BB after r369191.
Few BB failed with the following error:
Command Output (stderr):
--
/home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/test/tools/llvm-readobj/stack-sizes.test:263:19: error: BADSECTION-OUT: expected string not found in input
# BADSECTION-OUT: 8 ?
^
<stdin>:4:1: note: scanning from here
^
It doesn't reproduce on ubuntu/windows I have. Also, seems many of the bots
are happy too.
This slightly reorders the code to make fouts().flush() call earlier,
like it was before the r369191.
Modified:
llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp
Modified: llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp?rev=369192&r1=369191&r2=369192&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp (original)
+++ llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp Sat Aug 17 08:24:16 2019
@@ -395,14 +395,14 @@ LLVM_ATTRIBUTE_NORETURN void reportError
void reportWarning(Error Err, StringRef Input) {
assert(Err);
+ // Flush the standard output to print the warning at a
+ // proper place.
+ fouts().flush();
if (Input == "-")
Input = "<stdin>";
handleAllErrors(createFileError(Input, std::move(Err)),
[&](const ErrorInfoBase &EI) {
- // Flush the standard output to print the warning at a
- // proper place.
- fouts().flush();
errs() << "\n";
WithColor::warning(errs()) << EI.message() << "\n";
});
More information about the llvm-commits
mailing list