[PATCH] D65983: Autogenerate the shebang lines for tools/opt-viewer
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 16 15:42:20 PDT 2019
compnerd added a comment.
At least for the from-source distribution, where the destination of the image is the build host, `Python_EXECUTABLE` is definitely preferable (e.g. `#!@Python_EXECUTABLE@`). Furthermore, there is no reason to assume that `/usr/bin/env python3` will give you the same python 3 as what was given to cmake (you can control that with `-DPython_EXECUTABLE=...`). I think that requiring the user to specify the tool is possibly the best option - that is completely remove the shebang as that ensures that shifts the burden of selection to the user. Another option may be to use something like p2exe and create self-contained tools.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65983/new/
https://reviews.llvm.org/D65983
More information about the llvm-commits
mailing list